Repository navigation
Update ruby-gem-release to 0.6.0 - #19
Merged
Merged
Conversation
Contributor
Danger ReportNo issues found. |
Upgrade the gem and reusable workflow together, migrate the release context fixture, and align manual tasks and recovery documentation with the current release API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
update-ruby-gem-release-0.5.0
branch
from
November 15, 2026 13:58
c51f8aa to
be739d0
Compare
This was referenced Nov 15, 2026
numbata
approved these changes
Nov 15, 2026
dblock
added a commit
that referenced
this pull request
Nov 15, 2026
## Summary Make sticky report comments reliable without changing the report format or adding new inputs. - Paginate the complete PR comment list instead of considering only the first 100 comments. - Update only comments authored by `github-actions[bot]` with `Bot` metadata and the configured marker at the beginning of the body on its own line. Leave human comments, other bots, quoted markers, and other report markers untouched. - Serialize writers sharing the caller repository, source repository ID, head branch, and marker, without cancelling an active writer. Use trusted `workflow_run` source metadata rather than report contents, including for fork contributions. Different markers remain independent. - Add workflow-script regression tests for pagination, ownership, marker matching, repeated publication, and concurrency-group isolation. This is independent of #19 and #20 and targets `main` directly; it does not include their commits. It complements the report binding in #20 rather than replacing that validation. Quiet mode remains separate. GitHub concurrency does not guarantee execution order, so this change does not promise newest-report selection or clean up pre-existing duplicates. ## Validation - 36 examples passed: `bundle exec rspec spec/scripts/sticky_comment_workflow_spec.rb spec/scripts/install_workflows_spec.rb` - `bundle exec rubocop`: 14 files, no offenses - `actionlint .github/workflows/danger-comment.yml` - `node --check spec/fixtures/run_sticky_comment_workflow.js` - `git diff --check` AI-authored by GitHub Copilot on behalf of @dblock. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
that referenced
this pull request
Nov 15, 2026
## Summary Bump the next gem version to `0.3.0` for this new feature. Add one positive boolean input, `comment-empty`, defaulting to `true` so existing behavior remains unchanged. With `comment-empty: false`, an entirely empty report does not create a new PR comment. Errors, warnings, messages, or markdown still produce a comment. Existing report comments are always updated, including to "No issues found" when earlier findings clear. Emptiness is based on report content, not whether the Danger command passed. The input is passed through the environment rather than interpolated into executable JavaScript. Document the input and add regression tests that execute the actual commenter script using the workflow input defaults and environment mappings. This is a separate PR targeting `main`; #19, #20, and #21 remain unchanged. ## Validation - 31 examples passed: `bundle exec rspec spec/danger-pr-comment/version_spec.rb spec/scripts/empty_comment_workflow_spec.rb spec/scripts/install_workflows_spec.rb` - `bundle exec rubocop`: 14 files, no offenses; version file lint rechecked after the bump - Verified the gemspec version is `0.3.0` - `actionlint .github/workflows/danger-comment.yml` - `node --check spec/fixtures/run_empty_comment_workflow.js` - `git diff --check` AI-authored by GitHub Copilot on behalf of @dblock. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin the gem to the latest published release,
0.6.0, and the reusable release workflow to@v0.6.0. Migrate the spec release context fromprevious_version:togemspec_version:and update release documentation for renamed tasks, checkpoint-before-publication ordering, checksum-verified retries, andRELEASE_DATA_DIR. Point upstream recovery and task links atv0.6.0.Keep the standard workflow configuration and project-specific workflow-reference updater unchanged. No semantic-release behavior, custom hooks, or callbacks are enabled.
Validation
bundle exec rake: 40 examples passed and RuboCop clean across 13 files against the published0.6.0gem. Gem build, workflow lint, task listing, andgit diff --checkpassed. Local Ruby: 4.0.9; release workflow remains Ruby 3.3. No release dispatched or repository settings changed.AI-authored by GitHub Copilot on behalf of @dblock.