Skip to content

Update ruby-gem-release to 0.6.0 - #19

Merged
dblock merged 1 commit into
danger:mainfrom
dblock:update-ruby-gem-release-0.5.0
Nov 15, 2026
Merged

dblock merged 1 commit into
danger:mainfrom
dblock:update-ruby-gem-release-0.5.0

Conversation

@dblock

@dblock dblock commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Pin the gem to the latest published release, 0.6.0, and the reusable release workflow to @v0.6.0. Migrate the spec release context from previous_version: to gemspec_version: and update release documentation for renamed tasks, checkpoint-before-publication ordering, checksum-verified retries, and RELEASE_DATA_DIR. Point upstream recovery and task links at v0.6.0.

Keep the standard workflow configuration and project-specific workflow-reference updater unchanged. No semantic-release behavior, custom hooks, or callbacks are enabled.

Validation

bundle exec rake: 40 examples passed and RuboCop clean across 13 files against the published 0.6.0 gem. Gem build, workflow lint, task listing, and git diff --check passed. Local Ruby: 4.0.9; release workflow remains Ruby 3.3. No release dispatched or repository settings changed.

AI-authored by GitHub Copilot on behalf of @dblock.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Danger Report

No issues found.

View run

Upgrade the gem and reusable workflow together, migrate the release context fixture, and align manual tasks and recovery documentation with the current release API.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock force-pushed the update-ruby-gem-release-0.5.0 branch from c51f8aa to be739d0 Compare November 15, 2026 13:58
@dblock dblock changed the title Update ruby-gem-release to 0.5.0 Update ruby-gem-release to 0.6.0 Nov 15, 2026
@dblock
dblock requested a review from numbata November 15, 2026 13:59
@dblock
dblock merged commit 2265cc4 into danger:main Nov 15, 2026
4 checks passed
dblock added a commit that referenced this pull request Nov 15, 2026
## Summary

Make sticky report comments reliable without changing the report format
or adding new inputs.

- Paginate the complete PR comment list instead of considering only the
first 100 comments.
- Update only comments authored by `github-actions[bot]` with `Bot`
metadata and the configured marker at the beginning of the body on its
own line. Leave human comments, other bots, quoted markers, and other
report markers untouched.
- Serialize writers sharing the caller repository, source repository ID,
head branch, and marker, without cancelling an active writer. Use
trusted `workflow_run` source metadata rather than report contents,
including for fork contributions. Different markers remain independent.
- Add workflow-script regression tests for pagination, ownership, marker
matching, repeated publication, and concurrency-group isolation.

This is independent of #19 and #20 and targets `main` directly; it does
not include their commits. It complements the report binding in #20
rather than replacing that validation. Quiet mode remains separate.
GitHub concurrency does not guarantee execution order, so this change
does not promise newest-report selection or clean up pre-existing
duplicates.

## Validation

- 36 examples passed: `bundle exec rspec
spec/scripts/sticky_comment_workflow_spec.rb
spec/scripts/install_workflows_spec.rb`
- `bundle exec rubocop`: 14 files, no offenses
- `actionlint .github/workflows/danger-comment.yml`
- `node --check spec/fixtures/run_sticky_comment_workflow.js`
- `git diff --check`

AI-authored by GitHub Copilot on behalf of @dblock.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock added a commit that referenced this pull request Nov 15, 2026
## Summary

Bump the next gem version to `0.3.0` for this new feature.

Add one positive boolean input, `comment-empty`, defaulting to `true` so
existing behavior remains unchanged.

With `comment-empty: false`, an entirely empty report does not create a
new PR comment. Errors, warnings, messages, or markdown still produce a
comment. Existing report comments are always updated, including to "No
issues found" when earlier findings clear.

Emptiness is based on report content, not whether the Danger command
passed. The input is passed through the environment rather than
interpolated into executable JavaScript.

Document the input and add regression tests that execute the actual
commenter script using the workflow input defaults and environment
mappings. This is a separate PR targeting `main`; #19, #20, and #21
remain unchanged.

## Validation

- 31 examples passed: `bundle exec rspec
spec/danger-pr-comment/version_spec.rb
spec/scripts/empty_comment_workflow_spec.rb
spec/scripts/install_workflows_spec.rb`
- `bundle exec rubocop`: 14 files, no offenses; version file lint
rechecked after the bump
- Verified the gemspec version is `0.3.0`
- `actionlint .github/workflows/danger-comment.yml`
- `node --check spec/fixtures/run_empty_comment_workflow.js`
- `git diff --check`

AI-authored by GitHub Copilot on behalf of @dblock.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants